lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1602) Refactor SOLR package structure to include o.a.solr.response and move QueryResponseWriters in there
Date Fri, 01 Jan 2010 03:10:29 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795727#action_12795727
] 

Hoss Man commented on SOLR-1602:
--------------------------------


I've got no strong opinions about moving the code (it would probably be easier to understand
if we changed it, but so many people use IDEs these days that i odn't know if it matters)
but if we do change it i'd prefer to go the deprecation route just out of consistency with
how we've dealt with the RequestHandlers and other utilities classes in the past -- it's relatively
trivial to do, so there's very little down side -- and while it's true someone w/ deprecation
warnings turned off probably won't notice -- that's kind of the point behind doing deprecations,
you get them if you want, you ignore them if you don't -- but things don't break.

additionally: the config file issue should not be downplayed.  yes it would be a trivial search/replace,
but that's precisely the reason why it would aggravate users: because it would be such a trivial
change w/o any obvious benefit to the users.

(novice developers tend to be much more forgiving of eccentricities in the code base then
novice  users are of upgrade incompatibilities)




> Refactor SOLR package structure to include o.a.solr.response and move QueryResponseWriters
in there
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1602
>                 URL: https://issues.apache.org/jira/browse/SOLR-1602
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: independent of environment (code structure)
>            Reporter: Chris A. Mattmann
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1602.Mattmann.112509.patch.txt, SOLR-1602.Mattmann.112509_02.patch.txt
>
>
> Currently all o.a.solr.request.QueryResponseWriter implementations are curiously located
in the o.a.solr.request package. Not only is this package getting big (30+ classes), a lot
of them are misplaced. There should be a first-class o.a.solr.response package, and the response
related classes should be given a home there. Patch forthcoming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message