lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <>
Subject [jira] Commented: (SOLR-1602) Refactor SOLR package structure to include o.a.solr.response and move QueryResponseWriters in there
Date Mon, 04 Jan 2010 07:52:55 GMT


Shalin Shekhar Mangar commented on SOLR-1602:

One that springs to mind is updateRequestProcessor going to updateRequestProcessorChain.

Patrick, I think that change was made in trunk before update processors were ever released.

I'm both a software developer and a user of SOLR, and the consistent resistance to any proposed
refactoring is quite troubling.

The resistance is not towards refactoring. We are arguing about compatibility, not refactoring.

And as I noted from a code organization standpoint, placing classes named response in a package
named request is not subjectively anything - it's poor design and it needs to be addressed.

I bet 99% of the users do not care about a wrongly named package when everything works. But
they care when things stop working. Code organization is secondary to usability. Let us not
cause discomfort to our users for such a trivial issue.

As for "no apparent reason" as I mentioned to Noble, end-users of a system don't dictate its
code-level organization/design.

End users do not dictate code level organization but they do have an influence when compatibility
is involved. In this case, it is an inconvenience for many of them which can be avoided easily,
so why not?

I agree with Hoss. This is too much discussion over too small an issue. I think things are
quite clear. Hoss, Erik, Noble and I all feel that breaking compatibility is not worth it.
So lets do what needs to be done and get on with more important things.

> Refactor SOLR package structure to include o.a.solr.response and move QueryResponseWriters
in there
> ---------------------------------------------------------------------------------------------------
>                 Key: SOLR-1602
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: independent of environment (code structure)
>            Reporter: Chris A. Mattmann
>            Assignee: Noble Paul
>             Fix For: 1.5
>         Attachments: SOLR-1602.Mattmann.112509.patch.txt, SOLR-1602.Mattmann.112509_02.patch.txt,
> Currently all o.a.solr.request.QueryResponseWriter implementations are curiously located
in the o.a.solr.request package. Not only is this package getting big (30+ classes), a lot
of them are misplaced. There should be a first-class o.a.solr.response package, and the response
related classes should be given a home there. Patch forthcoming.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message