Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org Received: (qmail 75322 invoked from network); 11 Dec 2009 16:55:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Dec 2009 16:55:50 -0000 Received: (qmail 48045 invoked by uid 500); 11 Dec 2009 16:55:49 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 47971 invoked by uid 500); 11 Dec 2009 16:55:49 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 47961 invoked by uid 99); 11 Dec 2009 16:55:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2009 16:55:49 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2009 16:55:39 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 90295234C1E9 for ; Fri, 11 Dec 2009 08:55:18 -0800 (PST) Message-ID: <575466380.1260550518575.JavaMail.jira@brutus> Date: Fri, 11 Dec 2009 16:55:18 +0000 (UTC) From: "Marc Menghin (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Commented: (SOLR-236) Field collapsing In-Reply-To: <19014374.1178921656142.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-236?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D127893= 81#action_12789381 ]=20 Marc Menghin commented on SOLR-236: ----------------------------------- Hi, new to Solr, so sorry for my likely still incomplete setup. I got everythin= g from Solr SVN and applied the Patch (field-collapse-5.patch=092009-12-08 = 09:43 PM). As I search I get a NPE because I seem to not have a cache for t= he collapsing. It wants to add a entry to the cache but can't. There is non= e at that time, which it checks before in AbstractDocumentCollapser.collaps= e but still wants to use it later in AbstractDocumentCollapser.createDocume= ntCollapseResult. I suppose thats a bug? Or is something wrong on my side? Exception I get is: java.lang.NullPointerException =09at org.apache.solr.search.fieldcollapse.AbstractDocumentCollapser.create= DocumentCollapseResult(AbstractDocumentCollapser.java:278) =09at org.apache.solr.search.fieldcollapse.AbstractDocumentCollapser.execut= eCollapse(AbstractDocumentCollapser.java:249) =09at org.apache.solr.search.fieldcollapse.AbstractDocumentCollapser.collap= se(AbstractDocumentCollapser.java:172) =09at org.apache.solr.handler.component.CollapseComponent.doProcess(Collaps= eComponent.java:173) =09at org.apache.solr.handler.component.CollapseComponent.process(CollapseC= omponent.java:127) =09at org.apache.solr.handler.component.SearchHandler.handleRequestBody(Sea= rchHandler.java:195) =09at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandl= erBase.java:131) =09at org.apache.solr.core.SolrCore.execute(SolrCore.java:1316) I fixed it locally by only adding something to the cache if there is one (f= ieldCollapseCache !=3D null). But I'm not very into the code so not sure if= thats a good/right way to fix it. Thanks, Marc > Field collapsing > ---------------- > > Key: SOLR-236 > URL: https://issues.apache.org/jira/browse/SOLR-236 > Project: Solr > Issue Type: New Feature > Components: search > Affects Versions: 1.3 > Reporter: Emmanuel Keller > Fix For: 1.5 > > Attachments: collapsing-patch-to-1.3.0-dieter.patch, collapsing-p= atch-to-1.3.0-ivan.patch, collapsing-patch-to-1.3.0-ivan_2.patch, collapsin= g-patch-to-1.3.0-ivan_3.patch, field-collapse-3.patch, field-collapse-4-wit= h-solrj.patch, field-collapse-5.patch, field-collapse-5.patch, field-collap= se-5.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-= 5.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.p= atch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patc= h, field-collapse-5.patch, field-collapse-5.patch, field-collapse-solr-236-= 2.patch, field-collapse-solr-236.patch, field-collapsing-extended-592129.pa= tch, field_collapsing_1.1.0.patch, field_collapsing_1.3.patch, field_collap= sing_dsteigerwald.diff, field_collapsing_dsteigerwald.diff, field_collapsin= g_dsteigerwald.diff, quasidistributed.additional.patch, SOLR-236-FieldColla= psing.patch, SOLR-236-FieldCollapsing.patch, SOLR-236-FieldCollapsing.patch= , solr-236.patch, SOLR-236_collapsing.patch, SOLR-236_collapsing.patch > > > This patch include a new feature called "Field collapsing". > "Used in order to collapse a group of results with similar value for a gi= ven field to a single entry in the result set. Site collapsing is a special= case of this, where all results for a given web site is collapsed into one= or two entries in the result set, typically with an associated "more docum= ents from this site" link. See also Duplicate detection." > http://www.fastsearch.com/glossary.aspx?m=3D48&amid=3D299 > The implementation add 3 new query parameters (SolrParams): > "collapse.field" to choose the field used to group results > "collapse.type" normal (default value) or adjacent > "collapse.max" to select how many continuous results are allowed before c= ollapsing > TODO (in progress): > - More documentation (on source code) > - Test cases > Two patches: > - "field_collapsing.patch" for current development version > - "field_collapsing_1.1.0.patch" for Solr-1.1.0 > P.S.: Feedback and misspelling correction are welcome ;-) --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.