Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Message-ID: <1319666113.1261044378090.JavaMail.jira@brutus>
Date: Thu, 17 Dec 2009 10:06:18 +0000 (UTC)
From: "Noble Paul (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Updated: (SOLR-1664) Some Methods in FieldType actually
 should be in SchemaField
In-Reply-To: <1824560977.1261035378235.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/SOLR-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1664:
-----------------------------

    Description: 
The following methods are only overridable from FieldType. 
{code:java}
public Field createField(SchemaField field, String externalVal, float boost) ;
protected Field.TermVector getFieldTermVec(SchemaField field,String internalVal) ;
protected Field.Store getFieldStore(SchemaField field,String internalVal);
protected Field.Index getFieldIndex(SchemaField field,String internalVal);
public ValueSource getValueSource(SchemaField field, QParser parser);
public Query getRangeQuery(QParser parser, SchemaField field, String part1, String part2, boolean minInclusive, boolean maxInclusive) ;
{code}
if there is anything specific to be done on a per-field basis it is not possible. if we allow overriding SchemaField it will be more flexible.

I hope this can make it simpler to implement SOLR-1131

So ,there are two ways of overriding a functionality.
* Override Fieldtype#createSchemaField() and provide new implementation of SchemaField
* Override methods from FieldType itself(if the behavior is not per field ) as it is now

SchemaField is made non-final and Solr only invokes methods on SchemaField only


  was:
A lot of methods in FieldType actually should be in SchemaField. As we can see , all the following methods require SchemaField as an argument. The point is that most of the information is only available w/ SchemaField
{code:java}
public Field createField(SchemaField field, String externalVal, float boost) ;
protected Field.TermVector getFieldTermVec(SchemaField field,String internalVal) ;
protected Field.Store getFieldStore(SchemaField field,String internalVal);
protected Field.Index getFieldIndex(SchemaField field,String internalVal);
public ValueSource getValueSource(SchemaField field, QParser parser);
public Query getRangeQuery(QParser parser, SchemaField field, String part1, String part2, boolean minInclusive, boolean maxInclusive) ;
{code}

As an enhancement we should treat FieldType as a factory for SchemaField and make SchemaField non final


> Some Methods in FieldType actually should be in SchemaField
> -----------------------------------------------------------
>
>                 Key: SOLR-1664
>                 URL: https://issues.apache.org/jira/browse/SOLR-1664
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1664.patch
>
>
> The following methods are only overridable from FieldType. 
> {code:java}
> public Field createField(SchemaField field, String externalVal, float boost) ;
> protected Field.TermVector getFieldTermVec(SchemaField field,String internalVal) ;
> protected Field.Store getFieldStore(SchemaField field,String internalVal);
> protected Field.Index getFieldIndex(SchemaField field,String internalVal);
> public ValueSource getValueSource(SchemaField field, QParser parser);
> public Query getRangeQuery(QParser parser, SchemaField field, String part1, String part2, boolean minInclusive, boolean maxInclusive) ;
> {code}
> if there is anything specific to be done on a per-field basis it is not possible. if we allow overriding SchemaField it will be more flexible.
> I hope this can make it simpler to implement SOLR-1131
> So ,there are two ways of overriding a functionality.
> * Override Fieldtype#createSchemaField() and provide new implementation of SchemaField
> * Override methods from FieldType itself(if the behavior is not per field ) as it is now
> SchemaField is made non-final and Solr only invokes methods on SchemaField only

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.