lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-236) Field collapsing
Date Fri, 18 Dec 2009 05:42:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792350#action_12792350
] 

Shalin Shekhar Mangar commented on SOLR-236:
--------------------------------------------

For Martijn:

{quote}
The reason I added <fieldCollapsing> ... </fieldCollapsing> was to be able support
sharing of collapseCollectorFactory instances between different collapse components in the
near future. You think that is a valid reason for that? Or do you think that collapseCollectorFactories
shouldn't be shared?
{quote}

I just don't think that we should introduce new tags and new kinds of components in solrconfig.xml,
particularly those that are useful to only a single component. That introduces changes in
SolrConfig.java so that it knows how to load such things. That is why I moved that configuration
inside CollapseComponent. Ideally, all components will use PluginInfo and load whatever they
need from their own PluginInfo object and SolrConfig would not need to be changed unless we
introduce new kinds of Solr plugins.

Just curious, what would be a use-case for sharing factories (other than reducing duplication
of configuration) and having multiple CollapseComponent?

{quote}
The CollapseComponentTest was failing. The field collapseCollectorFactories in CollapseComponent
was null when not specifying any collapse collector factories in the solrconfig.xml which
resulted in a NPE.
{quote}

Oops, sorry about that. I only ran the tests inside org.apache.solr.search.fieldcollapse.
I didn't notice there are other tests too. Thanks!

bq. The DistributedFieldCollapsingIntegrationTest is still failing, because you left out changes
in JettySolrRunner, CoreContainer and SolrDispatchFilter from my original patch.

I don't think we need to add that functionality to CoreContainer and SolrDispatchFilter. It
is still possible to specify a different solrconfig and schema for a test. Let me see if I
can make this work with BaseDistributedSearchTestCase

> Field collapsing
> ----------------
>
>                 Key: SOLR-236
>                 URL: https://issues.apache.org/jira/browse/SOLR-236
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Emmanuel Keller
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.5
>
>         Attachments: collapsing-patch-to-1.3.0-dieter.patch, collapsing-patch-to-1.3.0-ivan.patch,
collapsing-patch-to-1.3.0-ivan_2.patch, collapsing-patch-to-1.3.0-ivan_3.patch, field-collapse-3.patch,
field-collapse-4-with-solrj.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch,
field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch,
field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch,
field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch, field-collapse-5.patch,
field-collapse-solr-236-2.patch, field-collapse-solr-236.patch, field-collapsing-extended-592129.patch,
field_collapsing_1.1.0.patch, field_collapsing_1.3.patch, field_collapsing_dsteigerwald.diff,
field_collapsing_dsteigerwald.diff, field_collapsing_dsteigerwald.diff, quasidistributed.additional.patch,
SOLR-236-FieldCollapsing.patch, SOLR-236-FieldCollapsing.patch, SOLR-236-FieldCollapsing.patch,
SOLR-236.patch, SOLR-236.patch, solr-236.patch, SOLR-236_collapsing.patch, SOLR-236_collapsing.patch
>
>
> This patch include a new feature called "Field collapsing".
> "Used in order to collapse a group of results with similar value for a given field to
a single entry in the result set. Site collapsing is a special case of this, where all results
for a given web site is collapsed into one or two entries in the result set, typically with
an associated "more documents from this site" link. See also Duplicate detection."
> http://www.fastsearch.com/glossary.aspx?m=48&amid=299
> The implementation add 3 new query parameters (SolrParams):
> "collapse.field" to choose the field used to group results
> "collapse.type" normal (default value) or adjacent
> "collapse.max" to select how many continuous results are allowed before collapsing
> TODO (in progress):
> - More documentation (on source code)
> - Test cases
> Two patches:
> - "field_collapsing.patch" for current development version
> - "field_collapsing_1.1.0.patch" for Solr-1.1.0
> P.S.: Feedback and misspelling correction are welcome ;-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message