lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (SOLR-1668) Declarative configuration meta-data for Solr plugins
Date Fri, 18 Dec 2009 04:48:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792339#action_12792339
] 

Erik Hatcher edited comment on SOLR-1668 at 12/18/09 4:46 AM:
--------------------------------------------------------------

In looking at your patch in more detail, we're actually not far from agreeing.  It's the specifying
of the converter class in the annotation that I don't like.  It can be more implicit than
that, like "magic".  public void setPattern(Pattern pattern) - perfect, we agree 100% on that!

Sure, there's always some String -> Object converter in the process, as this config will
come from strings almost always.  But no need to clutter the plugin itself with converters.
 Make sense?

      was (Author: ehatcher):
    In looking at your patch in more detail, we're actually not far from agreeing.  It's the
specifying of the convert class in the annotation.  It can be more implicit than that, like
"magic".  public void setPattern(Pattern pattern) - perfect, we agree 100% on that!

Sure, there's always some String -> Object converter in the process, as this config will
come from strings almost always.  But no need to clutter the plugin itself with converters.
 Make sense?
  
> Declarative configuration meta-data for Solr plugins
> ----------------------------------------------------
>
>                 Key: SOLR-1668
>                 URL: https://issues.apache.org/jira/browse/SOLR-1668
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 1.4
>            Reporter: Uri Boness
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: commons-beanutils-1.8.2.jar, SOLR-1668.patch
>
>
> The idea here is for plugins in Solr to carry more meta data over their configuration.
This can be very useful for building tools around Solr where this meta data can be used to
assist users in configuring solr. One common mechanism to provide this meta data is by using
standard Java Beans for the different configuration constructs where the properties define
the configurable attributes and annotations are used to provide extra information about them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message