lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <>
Subject [jira] Commented: (SOLR-1664) Some Methods in FieldType actually should be in SchemaField
Date Fri, 18 Dec 2009 14:55:18 GMT


Yonik Seeley commented on SOLR-1664:

bq. The point is , if we wish to go down this path , this is the best opportunity to do that
because, SOLR-1131 is introducing wholesale changes to the FieldType API

I'm reviewing/changing SOLR-1131 now to actually limit the public interface changes to two
methods: isPolyFIeld() and createFields(). It's not being changed much at all.

I'm not against this change, but I think this issue should stand on it's own and not be linked
to SOLR-1131.

> Some Methods in FieldType actually should be in SchemaField
> -----------------------------------------------------------
>                 Key: SOLR-1664
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>             Fix For: 1.5
>         Attachments: SOLR-1664.patch
> The following methods are only overridable from FieldType. 
> {code:java}
> public Field createField(SchemaField field, String externalVal, float boost) ;
> protected Field.TermVector getFieldTermVec(SchemaField field,String internalVal) ;
> protected Field.Store getFieldStore(SchemaField field,String internalVal);
> protected Field.Index getFieldIndex(SchemaField field,String internalVal);
> public ValueSource getValueSource(SchemaField field, QParser parser);
> public Query getRangeQuery(QParser parser, SchemaField field, String part1, String part2,
boolean minInclusive, boolean maxInclusive) ;
> {code}
> if there is anything specific to be done on a per-field basis it is not possible. if
we allow overriding SchemaField it will be more flexible.
> I hope this can make it simpler to implement SOLR-1131
> So ,there are two ways of overriding a functionality.
> * Override Fieldtype#createSchemaField() and provide new implementation of SchemaField
> * Override methods from FieldType itself(if the behavior is not per field ) as it is
> SchemaField is made non-final and Solr only invokes methods on SchemaField and not FieldType

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message