lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noble Paul (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder
Date Sun, 13 Dec 2009 17:29:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789919#action_12789919
] 

Noble Paul commented on SOLR-1644:
----------------------------------

bq. if ((Boolean)rb.store.get(HighlightingComponent.DO_HIGHLIGHTING))

This may cause NPE

so it will look like 

if (rb.store.get(HighlightingComponent.DO_HIGHLIGHTING) == Boolean.TRUE)

definitely it looks verbose (ugly) . But the point is where do we stop? Which all components
qualify to be important enough. Is 'my component' more/lessimportant than FacetComponent.
If we set a coding standard , isn't that better? I believe the public API's  should have no
dependency on components .

> Provide a clean way to keep flags and helper objects in ResponseBuilder
> -----------------------------------------------------------------------
>
>                 Key: SOLR-1644
>                 URL: https://issues.apache.org/jira/browse/SOLR-1644
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.5
>
>         Attachments: SOLR-1644.patch
>
>
> Many components such as StatsComponent, FacetComponent etc keep flags and helper objects
in ResponseBuilder. Having to modify the ResponseBuilder for such things is a very kludgy
solution.
> Let us provide a clean way for components to keep arbitrary objects for the duration
of a (distributed) search request.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message