lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris A. Mattmann (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1131) Allow a single field type to index multiple fields
Date Fri, 11 Dec 2009 04:37:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789106#action_12789106
] 

Chris A. Mattmann commented on SOLR-1131:
-----------------------------------------

{quote}
A comma is more user friendly - spaces are often already used as delimiters in quite a few
places.
Why did you replace more optimized code that was already written in parsePoint with less optimized
code?
{quote}

Meh, I could go either way on the comma/space issue. It would be nice to be compatible with
an existing GeoPoint standard. I know georss uses space as the delimeter -- do you know of
any that use ","?

RE: optimized code, can you be explicit? I would argue the code I inserted is more optimized
from a readiability standpoint. It's a bit easier for your typical CS101 grad to understand.
All that was being done in the prior patch is a set of forwards/backwards isolation loops
to determine the start/end index to substring out, in case you have:

34.333      ,100.1 OR
34.333,100.1 OR
34.333,       100.1

At first blush, trying to understand that code was a bit harder than simply tokenizing on
the known delimeter, and then trimming each tokenized value.

{code}
  out = externalVal.split(",");
+      if(out.length != dimension){
+        throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "incompatible dimension
(" + dimension +
+            ") and values (" + externalVal + ").  Only " + i + " values specified");    
   
+      }
+      for(int j=0; j < out.length; j++){
+        out[j] = out[j].trim();
+      }
{code}




> Allow a single field type to index multiple fields
> --------------------------------------------------
>
>                 Key: SOLR-1131
>                 URL: https://issues.apache.org/jira/browse/SOLR-1131
>             Project: Solr
>          Issue Type: New Feature
>          Components: Schema and Analysis
>            Reporter: Ryan McKinley
>            Assignee: Grant Ingersoll
>             Fix For: 1.5
>
>         Attachments: SOLR-1131-IndexMultipleFields.patch, SOLR-1131.Mattmann.121009.patch.txt,
SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch, SOLR-1131.patch
>
>
> In a few special cases, it makes sense for a single "field" (the concept) to be indexed
as a set of Fields (lucene Field).  Consider SOLR-773.  The concept "point" may be best indexed
in a variety of ways:
>  * geohash (sincle lucene field)
>  * lat field, lon field (two double fields)
>  * cartesian tiers (a series of fields with tokens to say if it exists within that region)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message