lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1674) improve analysis tests, cut over to new API
Date Mon, 21 Dec 2009 12:23:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793174#action_12793174
] 

Shalin Shekhar Mangar commented on SOLR-1674:
---------------------------------------------

All tests pass after renaming protWords.txt to protwords.txt. Unfortunately, this is too big
to review in detail right now but I trust Robert to do the right thing :)

bq. If there are no objections I will commit this beautiful addition to our analysis tests
soon.

+1

> improve analysis tests, cut over to new API
> -------------------------------------------
>
>                 Key: SOLR-1674
>                 URL: https://issues.apache.org/jira/browse/SOLR-1674
>             Project: Solr
>          Issue Type: Test
>          Components: Schema and Analysis
>            Reporter: Robert Muir
>         Attachments: SOLR-1674.patch, SOLR-1674.patch
>
>
> This patch
> * converts all analysis tests to use the new tokenstream api
> * converts most tests to use the more stringent assertion mechanisms from lucene
> * adds new tests to improve coverage
> Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
> The problems with this filter are more serious, the previous tests were essentially a
no-op.
> The new tests for SynonymFilter test the current behavior, but have FIXMEs with what
I think the old test wanted to expect in the comments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message