lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uri Boness (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1123) Change the JSONResponseWriter content type
Date Sun, 13 Dec 2009 18:23:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789922#action_12789922
] 

Uri Boness commented on SOLR-1123:
----------------------------------

I think the main issue with the inheritance right now is that the QueryResponseWriter interface
is dealing with a Writer rather than with an OutputStream. This accounts for the hacky GenericBinaryResponseWriter.


Looking at SOLR-1516 I'm a bit confused. I always had the impression that the main idea behind
the response writers is that all they need to know is how to marshal a NamedList (so they
don't need explicit knowledge of documents, highlighting, etc...). But now the GenericTextResponseWriter
knows about documents (via the SingleResponseWriter). But perhaps I just go it wrong.

> Change the JSONResponseWriter content type
> ------------------------------------------
>
>                 Key: SOLR-1123
>                 URL: https://issues.apache.org/jira/browse/SOLR-1123
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Uri Boness
>             Fix For: 1.5
>
>         Attachments: JSON_contentType_incl_tests.patch
>
>
> Currently the jSON content type is not used. Instead the palin/text content type is used.
The reason for this as I understand is to enable viewing the json response as as text in the
browser. While this is valid argument, I do believe that there should at least be an option
to configure this writer to use the JSON content type. According to [RFC4627|http://www.ietf.org/rfc/rfc4627.txt]
the json content type needs to be application/json (and not text/x-json). The reason this
can be very helpful is that today you have plugins for browsers (e.g. [JSONView|http://brh.numbera.com/software/jsonview])
that can render any page with application/json content type in a user friendly manner (just
like xml is supported).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message