lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Harris (JIRA)" <>
Subject [jira] Created: (SOLR-1624) Highlighter bug with MultiValued field + TermPositions optimization
Date Fri, 04 Dec 2009 21:53:20 GMT
Highlighter bug with MultiValued field + TermPositions optimization

                 Key: SOLR-1624
             Project: Solr
          Issue Type: Bug
          Components: highlighter
    Affects Versions: 1.4
            Reporter: Chris Harris

When TermPositions are stored, then DefaultSolrHighlighter.doHighlighting(DocList docs, Query
query, SolrQueryRequest req, String[] defaultFields) currently initializes tstream only for
the first value of a multi-valued field. (Subsequent times through the loop reinitialization
is preempted by tots being non-null.) This means that the 2nd/3rd/etc. values are not considered
for highlighting purposes, resulting in missed highlights.

I'm attaching a patch with a test case to demonstrate the problem (testTermVecMultiValuedHighlight2),
as well as a proposed fix. All highlighter tests pass with this applied. The patch should
apply cleanly against the latest trunk.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message