lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Updated: (SOLR-1621) Allow current single core deployments to be specified by solr.xml
Date Fri, 11 Dec 2009 19:02:18 GMT

     [ https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Miller updated SOLR-1621:
------------------------------

    Attachment: SOLR-1621.patch

You mark setSolrConfigFilename as deprecated, but it simply doesn't work anymore either -
thats not really deprecation. I feel that deprecating solrconfig-filename should be its own
issue so thats a more clear entry in CHANGES. And it should prob be deprecated rather than
turned off out of the blue. I don't suppose its a big deal either way though.

You have also changed CoreContainer#getCores - but that change is unrelated to this patch.
I really feal an issue should just stick to the issue - it makes commits more clear. That
change (which isn't back compat anyway), should be its own commit.

This latest update removes a bunch of the unrelated changes.

The patch is still unfinished though - you removed my fix to use the solrconfig override without
replacing it with an alternative fix. As a result, some tests don't use the right config now,
and in particular, NoCacheHeaderTest is back to failing.

> Allow current single core deployments to be specified by solr.xml
> -----------------------------------------------------------------
>
>                 Key: SOLR-1621
>                 URL: https://issues.apache.org/jira/browse/SOLR-1621
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 1.5
>            Reporter: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch,
SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch
>
>
> supporting two different modes of deployments is turning out to be hard. This leads to
duplication of code. Moreover there is a lot of confusion on where do we put common configuration.
See the mail thread http://markmail.org/message/3m3rqvp2ckausjnf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message