lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uri Boness (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder
Date Fri, 11 Dec 2009 13:09:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789290#action_12789290
] 

Uri Boness commented on SOLR-1644:
----------------------------------

bq. We should not keep it static. public final should be good enough

Is there a special reason for this? Is the plan to have a KEY per component instance? If so,
how would it be possible to refer to the key from other components?

This is what I had in mind - Assuming Component1 computed something and registered it in the
store using KEY. Then Component2 can reuse this computation by accessing it as follows: 

{code}
Object someValue = rb.store.get(Component2.KEY);
// do something with someValue
{code}

> Provide a clean way to keep flags and helper objects in ResponseBuilder
> -----------------------------------------------------------------------
>
>                 Key: SOLR-1644
>                 URL: https://issues.apache.org/jira/browse/SOLR-1644
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.5
>
>         Attachments: SOLR-1644.patch
>
>
> Many components such as StatsComponent, FacetComponent etc keep flags and helper objects
in ResponseBuilder. Having to modify the ResponseBuilder for such things is a very kludgy
solution.
> Let us provide a clean way for components to keep arbitrary objects for the duration
of a (distributed) search request.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message