Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Message-ID: <2021261841.1258951119593.JavaMail.jira@brutus>
Date: Mon, 23 Nov 2009 04:38:39 +0000 (UTC)
From: "Chris A. Mattmann (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Updated: (SOLR-1592) Refactor XMLWriter startTag to allow
 arbitrary attributes to be written
In-Reply-To: <1704644525.1258950159678.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/SOLR-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris A. Mattmann updated SOLR-1592:
------------------------------------

    Attachment: SOLR-1592.Mattmann.112209_02.patch.txt

here's a cleaner version of the patch with a few more methods. I can add javadocs to them to explain them better, but I think this is a lot more flexible than the current methods that exist (see the patch I'm about to attach to SOLR-1586 as evidence).

> Refactor XMLWriter startTag to allow arbitrary attributes to be written
> -----------------------------------------------------------------------
>
>                 Key: SOLR-1592
>                 URL: https://issues.apache.org/jira/browse/SOLR-1592
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.4
>         Environment: My MacBook laptop.
>            Reporter: Chris A. Mattmann
>             Fix For: 1.5
>
>         Attachments: SOLR-1592.Mattmann.112209.patch.txt, SOLR-1592.Mattmann.112209_02.patch.txt
>
>
> There are certain cases in which a user would like to write arbitrary attributes as part of the XML output for a field tag. Case in point: I'd like to declare tags in the SOLR output that are e.g., georss namespace, like georss:point. Other users may want to declare myns:mytag tags, which should be perfectly legal as SOLR goes. This isn't currently possible with the XMLWriter implementation, which curiously only allows the attribute "name" to be included in the XML tags. 
> Coincidentally, users of XMLWriter aren't allowed to modify the <response outer XML tag to include those arbitrary namespaces (which was my original thought as a workaround for this). This wouldn't matter anyways, because by the time the user got to the FieldType#writeXML method, the header for the XML would have been written anyways.
> I've developed a workaround, and in doing so, allowed something that should have probably been allowed in the first place: allow a user to write arbitrary attributes (including xmlns:myns="myuri") as part of the XMLWriter#startTag function. I've kept the existing #startTag, but replaced its innards with versions of startTag that include startTagWithNamespaces, and startTagNoAttrs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.