Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Message-ID: <1013700525.1258070559612.JavaMail.jira@brutus>
Date: Fri, 13 Nov 2009 00:02:39 +0000 (UTC)
From: "Hoss Man (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Commented: (SOLR-1553) extended dismax query parser
In-Reply-To: <180617789.1257893127966.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777289#action_12777289 ] 

Hoss Man commented on SOLR-1553:
--------------------------------

I haven't looked at the patch, and i hope to find some time to do so prior to year with a "3" in it, but in the meantime...

bq. I guess one of the main questions is if this should remain separate from dismax, or if it should eventually replace dismax?

I think the right way to handle this is to let both *classes* coexist in the code base, but to start encouraging people to use the new/improved version by changing the default used when defType=dismax ... a note in CHANGES.txt that people who really want the old class should use defType=oldDismax, or explicitly declare the old parsing using the name "dismax" seems totally suitable (much as we did with LegacyDateField, and lucenePlusSort.

bq. Having the capability to do field selections from the query string can often be undesirable, if not even a security issue in some cases.

Assuming the new parser is well written (and i would expect nothing less from all you lucid folks) i imagine it wouldn't take too much work to make all of those various options controllable by params.  if nothing else, an "escapeTheseChars" type option would be nice brute force way to disable some stuff.

> extended dismax query parser
> ----------------------------
>
>                 Key: SOLR-1553
>                 URL: https://issues.apache.org/jira/browse/SOLR-1553
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>             Fix For: 1.5
>
>         Attachments: SOLR-1553.patch
>
>
> An improved user-facing query parser based on dismax

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.