Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of mike_a@mit.edu designates
 18.7.7.80 as permitted sender)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
Mime-Version: 1.0 (Apple Message framework v1075.2)
Subject: Re: [jira] Commented: (SOLR-785) Distributed SpellCheckComponent
From: Mike Anderson <mike_a@MIT.EDU>
In-Reply-To: <1067311016.1259601320968.JavaMail.jira@brutus>
Date: Mon, 30 Nov 2009 12:38:38 -0500
Content-Transfer-Encoding: 7bit
Message-Id: <01499D32-8747-4BFA-8369-58B1859E79CA@mit.edu>
References: <1067311016.1259601320968.JavaMail.jira@brutus>
To: solr-dev@lucene.apache.org

I use this patch, but had to make one minor edit to get it working  
(this was a long time, so I don't quite remember the bug I was trying  
to solve),

around line 174:
    for (ShardRequest sreq : rb.finished) {
+ 	if ((sreq.purpose & ShardRequest.PURPOSE_GET_TOP_IDS) != 0){
    		for (ShardResponse srsp : sreq.responses) {

and appropriate closing brace.

On Nov 30, 2009, at 12:15 PM, Shalin Shekhar Mangar (JIRA) wrote:

>
>    [ https://issues.apache.org/jira/browse/SOLR-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783748#action_12783748 
>  ]
>
> Shalin Shekhar Mangar commented on SOLR-785:
> --------------------------------------------
>
> Well, there is only finishStage in the patch which is of no use  
> alone. SpellCheckComponent needs to either generate shard requests  
> or piggyback on existing requests to merge the data in finishStage.
>
> This brings up interesting questions - How do we perform distributed  
> search for SearchComponents which are not added by default to  
> SearchHandler? Only if the chain has QueryComponent, can we modify  
> its requests. Otherwise we must issue new ShardRequests. Is assuming  
> that configuration of the search component chain is the same between  
> all shards OK?
>
>> Distributed SpellCheckComponent
>> -------------------------------
>>
>>                Key: SOLR-785
>>                URL: https://issues.apache.org/jira/browse/SOLR-785
>>            Project: Solr
>>         Issue Type: Improvement
>>         Components: spellchecker
>>           Reporter: Shalin Shekhar Mangar
>>           Assignee: Shalin Shekhar Mangar
>>            Fix For: 1.5
>>
>>        Attachments: spelling-shard.patch
>>
>>
>> Enhance the SpellCheckComponent to run in a distributed (sharded)  
>> environment.
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>