lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mattmann, Chris A (388J)" <>
Subject Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written
Date Tue, 24 Nov 2009 00:11:55 GMT
Hi Chris,

Thanks for the inputs: comments inline below:

> ...i think here may be a disconnect here between some of the goals you are
> describing and the purpose of XMLWriter.  XMLWriter was originally created
> to be a wrapper arround a that had convinent heper methods
> for generating a specific XML response format (ie: wt=xml) back before
> Solr even supported multiple output types.  The API was never really
> designed to be useful for generating XML response data cosisting of
> alternate XML structures.

Good to know -- I'll open up a new issue that includes a patch with javadoc
that states that because it was unclear to me looking at the XMLWriter code.

> Perhaps instead of making API additions/generalizations to XMLWriter, we
> should approach the problem differnelty and think about what a good
> reusable general pupose XML generation toolkit that could be used by
> custom response writers should look like, and then implement that --
> refactoring the existing XMLWriter class to use/extend this new class
> where possible?

Potentially -- my problem is, why is XMLWriter a sacred cow? There's not
even a SOLR namespace or DTD to go along with it? Why should users be able
to inject their own custom XML into it -- it would seem that FieldTypes have
the ability to do this anyways (e.g., I can declare any new type of field
and its XML output [without namespaces sure, but still])...


Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA

View raw message