lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Anderson <mik...@MIT.EDU>
Subject Re: [jira] Commented: (SOLR-785) Distributed SpellCheckComponent
Date Mon, 30 Nov 2009 18:09:29 GMT
I indeed just added it to the default /select StandardRequestHandler  
in the "last-components" array.

Would this issue of the QT parameter being stripped from shard  
requests fit into the CommComponent (SOLR-1431)? Or is removing QT in  
fact the desired behavior?

On Nov 30, 2009, at 12:59 PM, Shalin Shekhar Mangar wrote:

> On Mon, Nov 30, 2009 at 11:08 PM, Mike Anderson <mike_a@mit.edu>  
> wrote:
>
>> I use this patch, but had to make one minor edit to get it working  
>> (this
>> was a long time, so I don't quite remember the bug I was trying to  
>> solve),
>>
>> around line 174:
>>  for (ShardRequest sreq : rb.finished) {
>> +       if ((sreq.purpose & ShardRequest.PURPOSE_GET_TOP_IDS) != 0){
>>               for (ShardResponse srsp : sreq.responses) {
>>
>> and appropriate closing brace.
>>
>>
> Did you add the SpellCheckComponent to the default /select  
> SearchHandler? If
> one uses a different SearchHandler, the qt parameter is removed from  
> shard
> requests and therefore spellcheck results are not returned.
>
>
>>
>> On Nov 30, 2009, at 12:15 PM, Shalin Shekhar Mangar (JIRA) wrote:
>>
>>
>>>  [
>>> https://issues.apache.org/jira/browse/SOLR-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783748#action_12783748
>>> ]
>>>
>>> Shalin Shekhar Mangar commented on SOLR-785:
>>> --------------------------------------------
>>>
>>> Well, there is only finishStage in the patch which is of no use  
>>> alone.
>>> SpellCheckComponent needs to either generate shard requests or  
>>> piggyback on
>>> existing requests to merge the data in finishStage.
>>>
>>> This brings up interesting questions - How do we perform distributed
>>> search for SearchComponents which are not added by default to  
>>> SearchHandler?
>>> Only if the chain has QueryComponent, can we modify its requests.  
>>> Otherwise
>>> we must issue new ShardRequests. Is assuming that configuration of  
>>> the
>>> search component chain is the same between all shards OK?
>>>
>>> Distributed SpellCheckComponent
>>>> -------------------------------
>>>>
>>>>              Key: SOLR-785
>>>>              URL: https://issues.apache.org/jira/browse/SOLR-785
>>>>          Project: Solr
>>>>       Issue Type: Improvement
>>>>       Components: spellchecker
>>>>         Reporter: Shalin Shekhar Mangar
>>>>         Assignee: Shalin Shekhar Mangar
>>>>          Fix For: 1.5
>>>>
>>>>      Attachments: spelling-shard.patch
>>>>
>>>>
>>>> Enhance the SpellCheckComponent to run in a distributed (sharded)
>>>> environment.
>>>>
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>
>
> -- 
> Regards,
> Shalin Shekhar Mangar.


Mime
View raw message