lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1557) shards param not parsed as a multivalue param
Date Thu, 12 Nov 2009 20:30:39 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777168#action_12777168
] 

Hoss Man commented on SOLR-1557:
--------------------------------

bq. I wouldn't call it odd - it's the same well defined splitting code used in a few places
in solr.

...hmmm, it seemed odd to me.

SolrPluginUtils.split(String) was designed for splitting params that were delimited (it's
what "fl" uses) ... The shards param is using StrUtils.splitSmart() which handles quoting
and backslash escape characters -- neither of which really make sense for a list of URLs.

I'm totally fine with not allowing whitespace if you had a compelling reason for excluding
it -- i've been vocally opposed to supporting comma delimited values for things like this
anyway but we need to leave it for back compatibility -- my main concern is that we start
supporting "shard" it as a multivalued param.


> shards param not parsed as a multivalue param
> ---------------------------------------------
>
>                 Key: SOLR-1557
>                 URL: https://issues.apache.org/jira/browse/SOLR-1557
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.4
>            Reporter: Hoss Man
>             Fix For: 1.5
>
>
> the shards param currently uses some odd parsing code to split on "," ... it should both
allow whitespace, and allow the shards to be specified as a multi-valued param...
> http://old.nabble.com/Shards-param-accepts-spaces-between-commas--to25962879.html#a25962879

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message