lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris A. Mattmann (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1589) Make FieldType#toInternal throw explicit Exceptions when Field values don't validate
Date Mon, 23 Nov 2009 02:09:42 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781280#action_12781280
] 

Chris A. Mattmann commented on SOLR-1589:
-----------------------------------------

But SolrException != HttpRequestException, right? More, it's not a ServletContainerException.
It's a SolrException. So why should we limit ourselves to only those exceptions that ServletContainers
allow? I understand it from a client perspective (in terms of sending exceptions over the
wire on the RPC request/reply interaction and that fact that SOLR is built on top of HTTP/REST,
so we're limited to its exceptions), but I don't understand it from a I'm coding entirely
on the server side and I'd like to throw an Exception that's catchable on the server-side
perspective (w/o having to transfer the Exception over the wire). I think SOLR needs a mechanism
of defining such Exceptions since people may write code that's an entirely server side or
entirely client side operation. 

> Make FieldType#toInternal throw explicit Exceptions when Field values don't validate
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-1589
>                 URL: https://issues.apache.org/jira/browse/SOLR-1589
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.4
>         Environment: My MacBook pro laptop.
>            Reporter: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 1.5
>
>
> As discussed on the mailing list: 
> http://mail-archives.apache.org/mod_mbox/lucene-solr-dev/200911.mbox/%3C85641490-9E70-41B3-A32E-22935B6887B4@apache.org%3E
> I think we can do a better job of having explicit Exceptions when there is a problem
creating the internal representation of a Field, as defined by FieldType#toInternal. Instead
of throwing obscure RuntimeExceptions, let's create a FieldValidationException explicit type,
and make o.a.solr.schema.FieldType#toInternal throw this Exception as part of its signature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message