Return-Path: 
 <solr-dev-return-19530-apmail-lucene-solr-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org
Received: (qmail 42259 invoked from network); 7 Sep 2009 21:47:20 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 7 Sep 2009 21:47:20 -0000
Received: (qmail 39431 invoked by uid 500); 7 Sep 2009 21:47:20 -0000
Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org
Received: (qmail 39333 invoked by uid 500); 7 Sep 2009 21:47:20 -0000
Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:solr-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:solr-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:solr-dev@lucene.apache.org>
List-Id: <solr-dev.lucene.apache.org>
Reply-To: solr-dev@lucene.apache.org
Delivered-To: mailing list solr-dev@lucene.apache.org
Received: (qmail 39323 invoked by uid 99); 7 Sep 2009 21:47:20 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Sep 2009 21:47:19 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Sep 2009 21:47:17 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 917CD234C4B0
	for <solr-dev@lucene.apache.org>; Mon,  7 Sep 2009 14:46:57 -0700 (PDT)
Message-ID: <735833930.1252360017595.JavaMail.jira@brutus>
Date: Mon, 7 Sep 2009 14:46:57 -0700 (PDT)
From: "Yonik Seeley (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Issue Comment Edited: (SOLR-1071) spellcheck.extendedResults
 returns an invalid JSON response when count > 1
In-Reply-To: <1091095058.1237251350628.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752268#action_12752268 ] 

Yonik Seeley edited comment on SOLR-1071 at 9/7/09 2:45 PM:
------------------------------------------------------------

I'm moving forward with the most straightforward fix... the string becomes a map for extended results.  So
<str>dell</str> in non extended results becomes the following in extended results:
<lst>  <str name="word">dell</str> <int name="freq">1</int> </lst>

So voice your objections now ;-)

Actually, the code to do the change is already done... the hard part is the tests... and there seems to be no unit tests for the SolrJ part that actually test the Suggestion class.

      was (Author: yseeley@gmail.com):
    I'm moving forward with the most straightforward fix... the string becomes a map for extended results.  So
<str>dell</str> in non extended results because the following in extended results:
<lst>  <str name="word">dell</str> <int name="freq">1</int> </lst>

So voice your objections now ;-)

Actually, the code to do the change is already done... the hard part is the tests... and there seems to be no unit tests for the SolrJ part that actually test the Suggestion class.
  
> spellcheck.extendedResults returns an invalid JSON response when count > 1
> --------------------------------------------------------------------------
>
>                 Key: SOLR-1071
>                 URL: https://issues.apache.org/jira/browse/SOLR-1071
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 1.3
>            Reporter: Uri Boness
>            Assignee: Yonik Seeley
>             Fix For: 1.4
>
>         Attachments: SpellCheckComponent_fix.patch, SpellCheckComponent_new_structure.patch, SpellCheckComponent_new_structure_incl_test.patch
>
>
> When: wt=json & spellcheck.extendedResults=true & spellcheck.count > 1, the suggestions are returned in the following format:
> "suggestions":[
> 	"amsterdm",{
> 	 "numFound":5,
> 	 "startOffset":0,
> 	 "endOffset":8,
> 	 "origFreq":0,
> 	 "suggestion":{
> 	  "frequency":8498,
> 	  "word":"amsterdam"},
> 	 "suggestion":{
> 	  "frequency":1,
> 	  "word":"amsterd"},
> 	 "suggestion":{
> 	  "frequency":8,
> 	  "word":"amsterdams"},
> 	 "suggestion":{
> 	  "frequency":1,
> 	  "word":"amstedam"},
> 	 "suggestion":{
> 	  "frequency":22,
> 	  "word":"amsterdamse"}},
> 	"beak",{
> 	 "numFound":5,
> 	 "startOffset":9,
> 	 "endOffset":13,
> 	 "origFreq":0,
> 	 "suggestion":{
> 	  "frequency":379,
> 	  "word":"beek"},
> 	 "suggestion":{
> 	  "frequency":26,
> 	  "word":"beau"},
> 	 "suggestion":{
> 	  "frequency":26,
> 	  "word":"baak"},
> 	 "suggestion":{
> 	  "frequency":15,
> 	  "word":"teak"},
> 	 "suggestion":{
> 	  "frequency":11,
> 	  "word":"beuk"}},
> 	"correctlySpelled",false,
> 	"collation","amsterdam beek"]}}
> This is an invalid json as each term is associated with a JSON object which holds multiple "suggestion" attributes. When working with a JSON library only the last "suggestion" attribute is picked up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.