lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Rutherglen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1447) Simple property injection
Date Mon, 21 Sep 2009 22:31:16 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758050#action_12758050
] 

Jason Rutherglen commented on SOLR-1447:
----------------------------------------

Noble, looks good, and all tests pass.  I think it's tricky to commit this as is, because
there's no back compat?  Maybe we can allow:
{code}
<mergePolicy>org.apache.lucene.index.LogByteSizeMergePolicy</mergePolicy>
<mergeScheduler>org.apache.lucene.index.ConcurrentMergeScheduler</mergeScheduler>
{code}
or
{code}
<mergePolicy14 class="org.apache.lucene.index.LogByteSizeMergePolicy">
  <double name="maxMergeMB">64.0</double>
</mergePolicy14>
<mergeSceduler14 class="org.apache.lucene.index.ConcurrentMergeScheduler">
  <int name="maxThreadCount">3</int>
</mergeScheduler14>
{code}

It's ugly but more clear and this way users' installations won't immediately break on deployment.



> Simple property injection 
> --------------------------
>
>                 Key: SOLR-1447
>                 URL: https://issues.apache.org/jira/browse/SOLR-1447
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 1.4
>            Reporter: Jason Rutherglen
>            Assignee: Noble Paul
>            Priority: Trivial
>             Fix For: 1.4
>
>         Attachments: SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch, SOLR-1447.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> MergePolicy and MergeScheduler require property injection.  We'll allow these and probably
other cases in this patch using Java reflection.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message