lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Noble Paul (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (SOLR-1417) solrj DocumentObjectBinder prints to stdout rather than using slf4j
Date Wed, 09 Sep 2009 03:51:57 GMT

     [ https://issues.apache.org/jira/browse/SOLR-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Noble Paul resolved SOLR-1417.
------------------------------

    Resolution: Fixed

committed r812759 . The logging was just done for debugging purposes
Thanks Ilan 

> solrj DocumentObjectBinder prints to stdout rather than using slf4j
> -------------------------------------------------------------------
>
>                 Key: SOLR-1417
>                 URL: https://issues.apache.org/jira/browse/SOLR-1417
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 1.4
>            Reporter: Ilan Rabinovitch
>            Priority: Minor
>
> We have nnoticed that in trunk the inject method of DocumentObjectBinder [1] for solrj
logs to standard out using System.out.println if any variables in the returned result have
a null value.   Since system.out is not configurable this can get quite spammy on the console.
 
> Should this be logging at the INFO/DEBUG level using slf4j instead?  
> The system.out.println statement was added on 2009-07-14 as part of SOLR-1129 (r794144).
 
> ---
> [1] src/solrj/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java:316 (r794144)
>     <T> void inject(T obj, SolrDocument sdoc) {
>       Object val = getFieldValue(sdoc);
>       if(val == null) {
>         System.out.println("val null for "+ name);
>         return;
>       }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message