lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <>
Subject [jira] Updated: (SOLR-1470) index formats always compound
Date Mon, 28 Sep 2009 19:56:16 GMT


Shalin Shekhar Mangar updated SOLR-1470:

    Attachment: SOLR-1470.patch

setUseCompoundFile can only be invoked if the merge policy is an instance of LogMergePolicy.
So if the policy is not LogMergePolicy, we can't call that setter regardless of the value
of useCompoundFile. The previous patch is wrong because it will call setUseCompoundFile(false)
even if policy is not LogMergePolicy.

I think throwing an exception would be wrong because that would mean the policy must always
derive from LogMergePolicy. This patch logs a warning that if policy is not an instance of
LogMergePolicy, the value of useCompoundFile is not used and the configured policy's defaults
will take effect.

> index formats always compound
> -----------------------------
>                 Key: SOLR-1470
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>             Fix For: 1.4
>         Attachments: SOLR-1470.patch, SOLR-1470.patch, SOLR-1470.patch
> Seems like the index format is always compound now.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message