lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fergus McMenemie (JIRA)" <>
Subject [jira] Updated: (SOLR-1437) DIH: Enhance XPathRecordReader to deal with //tagname and other improvments.
Date Fri, 25 Sep 2009 05:39:16 GMT


Fergus McMenemie updated SOLR-1437:

    Attachment: SOLR-1437.patch

A patch of adding a few cosmetic changes to comments plus.....

A rewritten core of the parse() method. IMHO it is simpler to understand with the inner while
and special state variable removed and it is probably faster as well.

Rearranged method getOrAddChild renaming it to getOrAddNode in preparation for adding support
for // construct. This method is called from build().

While in build(), renamed local variable "name" to "xpseg" to better reflect that it holds
a segment from an Xpath. And to remove warnings about local variables masking class variables.

"ant clean test" runs OK with these changes!

> DIH: Enhance XPathRecordReader to deal with //tagname and other improvments.
> ----------------------------------------------------------------------------
>                 Key: SOLR-1437
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: Fergus McMenemie
>            Assignee: Noble Paul
>            Priority: Minor
>             Fix For: 1.5
>         Attachments: SOLR-1437.patch, SOLR-1437.patch, SOLR-1437.patch
>   Original Estimate: 672h
>  Remaining Estimate: 672h
> As per
it would be nice to be able to use expressions such as //tagname when parsing XML documents.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message