Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Message-ID: <1025128147.1251563972837.JavaMail.jira@brutus>
Date: Sat, 29 Aug 2009 09:39:32 -0700 (PDT)
From: "Mark Miller (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Commented: (SOLR-1319) Upgrade custom Solr Highlighter
 classes to new Lucene Highlighter API
In-Reply-To: <1679717221.1249050495067.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749163#action_12749163 ] 

Mark Miller commented on SOLR-1319:
-----------------------------------

The break is that {code}protected QueryTermScorer getQueryScorer(Query query, String fieldName, SolrQueryRequest request) {code} now has a different return type. Its too bad it wasnt done the same way as the SpanScorer - there you can just override the getSpanHighlighter call, but getting the Scorer is private.

So its a break, though no one was overriding it likely - we should almost make it private - you can anything you need to overriding the getHighlighter call. At least, I should have changed it to just Scorer rather than QueryTermScorer.

> Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
> ---------------------------------------------------------------------
>
>                 Key: SOLR-1319
>                 URL: https://issues.apache.org/jira/browse/SOLR-1319
>             Project: Solr
>          Issue Type: Task
>          Components: highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 1.4
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.