lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1319) Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
Date Sat, 29 Aug 2009 16:39:32 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749163#action_12749163
] 

Mark Miller commented on SOLR-1319:
-----------------------------------

The break is that {code}protected QueryTermScorer getQueryScorer(Query query, String fieldName,
SolrQueryRequest request) {code} now has a different return type. Its too bad it wasnt done
the same way as the SpanScorer - there you can just override the getSpanHighlighter call,
but getting the Scorer is private.

So its a break, though no one was overriding it likely - we should almost make it private
- you can anything you need to overriding the getHighlighter call. At least, I should have
changed it to just Scorer rather than QueryTermScorer.

> Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
> ---------------------------------------------------------------------
>
>                 Key: SOLR-1319
>                 URL: https://issues.apache.org/jira/browse/SOLR-1319
>             Project: Solr
>          Issue Type: Task
>          Components: highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 1.4
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message