Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org Received: (qmail 77584 invoked from network); 27 Jul 2009 22:05:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Jul 2009 22:05:41 -0000 Received: (qmail 81761 invoked by uid 500); 27 Jul 2009 22:06:45 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 81682 invoked by uid 500); 27 Jul 2009 22:06:45 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 81668 invoked by uid 99); 27 Jul 2009 22:06:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2009 22:06:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2009 22:06:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D365C234C046 for ; Mon, 27 Jul 2009 15:06:14 -0700 (PDT) Message-ID: <1054983140.1248732374864.JavaMail.jira@brutus> Date: Mon, 27 Jul 2009 15:06:14 -0700 (PDT) From: "Erik Hatcher (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Issue Comment Edited: (SOLR-1237) firstSearcher and newSearcher should identify themselves via the parameter set passed in In-Reply-To: <1338545546.1245720967390.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735803#action_12735803 ] Erik Hatcher edited comment on SOLR-1237 at 7/27/09 3:04 PM: ------------------------------------------------------------- Just a quick and petty comment: + public static final String NEW_SEARCHER = "newSrchr"; + public static final String FIRST_SEARCHER = "frstSrchr"; No need to abbreviate so obtusely! "newSearcher" and "firstSearcher" pretty please. was (Author: ehatcher): Just and petty comment: + public static final String NEW_SEARCHER = "newSrchr"; + public static final String FIRST_SEARCHER = "frstSrchr"; No need to abbreviate so obtusely! "newSearcher" and "firstSearcher" pretty please. > firstSearcher and newSearcher should identify themselves via the parameter set passed in > ---------------------------------------------------------------------------------------- > > Key: SOLR-1237 > URL: https://issues.apache.org/jira/browse/SOLR-1237 > Project: Solr > Issue Type: Improvement > Reporter: Grant Ingersoll > Assignee: Grant Ingersoll > Priority: Minor > Fix For: 1.4 > > Attachments: SOLR-1237.patch > > > The firstSearcher and newSearcher events call the regular search component chain, but are special cases. They should identify themselves by passing in a parameter indicating their type. This way, for instance, the sharding component could know to ignore the &shards parameter, which currently causes Solr to hang if it is present in the firstSearcher query string. > See http://www.lucidimagination.com/search/document/b2b9c39a8eb4e563/firstsearcher_and_newsearcher_events -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.