lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Donovan Jimenez (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1270) The FloatField (and probably others) field type takes any string value at index, but JSON writer outputs as numeric without checking
Date Wed, 22 Jul 2009 22:19:14 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734358#action_12734358
] 

Donovan Jimenez commented on SOLR-1270:
---------------------------------------

I'm preferential to doing the check at add document time if one is going to be done at all
because it fails early for the user. 

However, I have a counter proposal to changing the FloatField type.

Since FloatField is meant primarily for legacy purposes, why don't we change the distributed
example schema.xml to not use it for the "float" field type. If we're going for the 80/20
type mantra, then SortableFloatField is probably what most new users of Solr mean when they
want to specify a "float" field.  

Does that seem like a workable idea to try and remove the confusion around this issue?



> The FloatField (and probably others) field type takes any string value at index, but
JSON writer outputs as numeric without checking
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1270
>                 URL: https://issues.apache.org/jira/browse/SOLR-1270
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: ubuntu 8.04, sun java 6, tomcat 5.5
>            Reporter: Donovan Jimenez
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-1270.patch
>
>
> The FloatField field type takes any string value at index. These values aren't necessarily
in JSON numeric, but the JSON writer does not check its validity before writing it out as
a JSON numeric.
> I'm aware of the SortableFloatField which does do index time verification and conversion
of the value, but the way the JSON writer is working seemed like either a bug that needed
addressed or perhaps a gotch that needs better documented?
> This issue originally came from my php client issue tracker: http://code.google.com/p/solr-php-client/issues/detail?id=13

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message