lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Schraeder (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1270) The FloatField (and probably others) field type takes any string value at index, but JSON writer outputs as numeric without checking
Date Wed, 22 Jul 2009 19:35:15 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734267#action_12734267
] 

Matt Schraeder commented on SOLR-1270:
--------------------------------------

Hoss:  You're misunderstanding something.  In the case that the float field is less than 1,
for example: "0.5", then the JSON encoder spits out ".0" without the quotes.  This is invalid
JSON.  In THIS particular example, the value stored is valid, and the value returned is NOT
valid JSON. In order to be valid JSON, a float value of less than 1 needs a preceding 0 before
the decimal point or JSON thinks it should be a string and fails reading the value.

Your argument for not making it more paranoid is fine, I have no problems with that, but when
given valid data it should ALSO return valid data and in this case it is not.  

> The FloatField (and probably others) field type takes any string value at index, but
JSON writer outputs as numeric without checking
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1270
>                 URL: https://issues.apache.org/jira/browse/SOLR-1270
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: ubuntu 8.04, sun java 6, tomcat 5.5
>            Reporter: Donovan Jimenez
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-1270.patch
>
>
> The FloatField field type takes any string value at index. These values aren't necessarily
in JSON numeric, but the JSON writer does not check its validity before writing it out as
a JSON numeric.
> I'm aware of the SortableFloatField which does do index time verification and conversion
of the value, but the way the JSON writer is working seemed like either a bug that needed
addressed or perhaps a gotch that needs better documented?
> This issue originally came from my php client issue tracker: http://code.google.com/p/solr-php-client/issues/detail?id=13

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message