lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Hill (JIRA)" <j...@apache.org>
Subject [jira] Updated: (SOLR-1286) DIH: The commit parameter is always defaulting to "true" even if "false" is explicitly passed in.
Date Thu, 16 Jul 2009 18:54:14 GMT

     [ https://issues.apache.org/jira/browse/SOLR-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jay Hill updated SOLR-1286:
---------------------------

    Attachment: SOLR-1286.patch

Found the problem. There was a test to see if there was a value set for "optimize", if so,
no matter what it was, "commit" was set to "true":
      if (requestParams.containsKey("optimize")) {
        optimize = Boolean.parseBoolean((String) requestParams.get("optimize"));
        commit = true;
      }

But we had optimize=false set as an invariant so the simple presence of a value (false) caused
a commit to happen. Changed it to this:
      if (requestParams.containsKey("optimize")) {
        optimize = Boolean.parseBoolean((String) requestParams.get("optimize"));
        if (optimize)
          commit = true;
      }

I think that should do it.

> DIH: The commit parameter is always defaulting to "true" even if "false" is explicitly
passed in.
> -------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1286
>                 URL: https://issues.apache.org/jira/browse/SOLR-1286
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>            Reporter: Jay Hill
>            Assignee: Erik Hatcher
>             Fix For: 1.4
>
>         Attachments: SOLR-1286.patch, SOLR-1286.patch, SOLR-1286.patch, SOLR-1286.patch,
SOLR-1286.patch, SOLR-1286.patch
>
>
> I've tried running full and delta imports with commit=false so that the autoCommit will
manage all commits to the index. However setting commit=false doesn't have any effect: 
> curl 'http://localhost:8080/solr/dataimporter?command=full-import&commit=false'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message