lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (SOLR-1237) firstSearcher and newSearcher should identify themselves via the parameter set passed in
Date Mon, 27 Jul 2009 22:06:14 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735803#action_12735803
] 

Erik Hatcher edited comment on SOLR-1237 at 7/27/09 3:04 PM:
-------------------------------------------------------------

Just a quick and petty comment:

+  public static final String NEW_SEARCHER = "newSrchr";
+  public static final String FIRST_SEARCHER = "frstSrchr";

No need to abbreviate so obtusely!  "newSearcher" and "firstSearcher" pretty please.



      was (Author: ehatcher):
    Just and petty comment:

+  public static final String NEW_SEARCHER = "newSrchr";
+  public static final String FIRST_SEARCHER = "frstSrchr";

No need to abbreviate so obtusely!  "newSearcher" and "firstSearcher" pretty please.


  
> firstSearcher and newSearcher should identify themselves via the parameter set passed
in
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-1237
>                 URL: https://issues.apache.org/jira/browse/SOLR-1237
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-1237.patch
>
>
> The firstSearcher and newSearcher events call the regular search component chain, but
are special cases.  They should identify themselves by passing in a parameter indicating their
type.  This way, for instance, the sharding component could know to ignore the &shards
parameter, which currently causes Solr to hang if it is present in the firstSearcher query
string.
> See http://www.lucidimagination.com/search/document/b2b9c39a8eb4e563/firstsearcher_and_newsearcher_events

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message