Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org Received: (qmail 21978 invoked from network); 4 Jun 2009 13:05:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Jun 2009 13:05:18 -0000 Received: (qmail 64310 invoked by uid 500); 4 Jun 2009 13:05:30 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 64222 invoked by uid 500); 4 Jun 2009 13:05:30 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 64211 invoked by uid 99); 4 Jun 2009 13:05:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2009 13:05:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2009 13:05:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id F3F22234C051 for ; Thu, 4 Jun 2009 06:05:07 -0700 (PDT) Message-ID: <880405845.1244120707998.JavaMail.jira@brutus> Date: Thu, 4 Jun 2009 06:05:07 -0700 (PDT) From: "Mark Miller (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Updated: (SOLR-243) Create a hook to allow custom code to create custom IndexReaders In-Reply-To: <10909450.1179729796410.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-243: ----------------------------- Attachment: SOLR-243.patch to trunk, remove non readonly reader factory method and fixes readOnly propagation in a couple spots. > Create a hook to allow custom code to create custom IndexReaders > ---------------------------------------------------------------- > > Key: SOLR-243 > URL: https://issues.apache.org/jira/browse/SOLR-243 > Project: Solr > Issue Type: Improvement > Components: search > Environment: Solr core > Reporter: John Wang > Assignee: Mark Miller > Fix For: 1.5 > > Attachments: indexReaderFactory.patch, indexReaderFactory.patch, indexReaderFactory.patch, indexReaderFactory.patch, indexReaderFactory.patch, indexReaderFactory.patch, indexReaderFactory.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch, SOLR-243.patch > > > I have a customized IndexReader and I want to write a Solr plugin to use my derived IndexReader implementation. Currently IndexReader instantiation is hard coded to be: > IndexReader.open(path) > It would be really useful if this is done thru a plugable factory that can be configured, e.g. IndexReaderFactory > interface IndexReaderFactory{ > IndexReader newReader(String name,String path); > } > the default implementation would just return: IndexReader.open(path) > And in the newSearcher and getSearcher methods in SolrCore class can call the current factory implementation to get the IndexReader instance and then build the SolrIndexSearcher by passing in the reader. > It would be really nice to add this improvement soon (This seems to be a trivial addition) as our project really depends on this. > Thanks > -John -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.