Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org Received: (qmail 36816 invoked from network); 23 Jun 2009 13:47:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Jun 2009 13:47:19 -0000 Received: (qmail 67747 invoked by uid 500); 23 Jun 2009 13:47:30 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 67668 invoked by uid 500); 23 Jun 2009 13:47:30 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 67658 invoked by uid 99); 23 Jun 2009 13:47:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2009 13:47:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2009 13:47:27 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 968E6234C004 for ; Tue, 23 Jun 2009 06:47:07 -0700 (PDT) Message-ID: <2028047973.1245764827602.JavaMail.jira@brutus> Date: Tue, 23 Jun 2009 06:47:07 -0700 (PDT) From: "Yonik Seeley (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Commented: (SOLR-1236) stop using strings for filepaths and start using File objects In-Reply-To: <1300356347.1245716527498.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723076#action_12723076 ] Yonik Seeley commented on SOLR-1236: ------------------------------------ True - but we need to also keep in mind places that some things may want to map to things other than a local file in the future... for example, pointing to a resource such as a synonym file or other config that resides on HDFS or zookeeper. > stop using strings for filepaths and start using File objects > ------------------------------------------------------------- > > Key: SOLR-1236 > URL: https://issues.apache.org/jira/browse/SOLR-1236 > Project: Solr > Issue Type: Improvement > Reporter: Hoss Man > Priority: Trivial > > Catching up on my email after a long hiatus i notice SOLR-1213 and it reminded me that the last time i was digging arround in the code i was frustrated by lots of places in Solr where "String" instances to store a file or directory paths and then manipulated with String operations. I would be nice to switch all of these member variables and and function params to use genuine File objects to improve the code base readibility, and reduce the likelyhood of OS variant bugs or nonsensical path operations. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.