lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacob Singh (JIRA)" <>
Subject [jira] Commented: (SOLR-1173) Let contrib projects modify web.xml when running dist-war
Date Sat, 20 Jun 2009 06:00:10 GMT


Jacob Singh commented on SOLR-1173:

"If i understand the motivation for this, it's that an expert user (jacob) has private modifications
(not intended for being committed into the ASF repository) and is requesting modifications
to the solr build files to make this modifications possible when he builds his own version
of solr - not when using an official build."

Not exactly.  I don't have a modifications, I build a new contrib jar which needs to have
its filter configured in web.xml.  It's not a modification to Solr code, and the war target,
not the build target.  What I was proposing is that in the future, if any contrib modules
needed web.xml extensions, they would have to break the build/war processes, and this 10 line
patch prevents that without causing any other disruption; just like all the rest of the steps
which use contrib-crawl.

Still, I guess I'm outnumbered, so we'll just have to keep maintaining our modification :)
 But there's the rationale.


> Let contrib projects modify web.xml when running dist-war
> ---------------------------------------------------------
>                 Key: SOLR-1173
>                 URL:
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Jacob Singh
>             Fix For: 1.5
>         Attachments: xmltask_contrib_build.diff, xmltask_contrib_build.diff
> Original problem:
> I just wrote a Servlet Filter to handle authentication for our
> service.  Here's what I did:
> 1. Created a dir in contrib
> 2. Put my project in there, I took the dataimporthandler build.xml as
> an example and modified it to suit my needs.  Worked great!
> 3. ant dist now builds my jar and includes it
> I now need to modify web.xml to add my filter-mapping, init params,
> etc.  How can I do this cleanly?  Or do I need to manually open up the
> archive and edit it and then re-war it?
> In common-build I don't see a target for dist-war, so don't see how it
> is possible...
> See:

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message