lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-940) TrieRange support
Date Thu, 25 Jun 2009 08:11:07 GMT

    [ https://issues.apache.org/jira/browse/SOLR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723938#action_12723938
] 

Uwe Schindler commented on SOLR-940:
------------------------------------

{quote}
Regarding Collector#acceptsDocsOutOfOrder, I think we need to
# Return true when we do not need scores, otherwise false. 
# DocSetCollector and DocSetDelegateCollector collect in order so we return false 
It'd be great if someone who know more about this stuff can confirm.
{quote}

My explanation without guarantee: If you set it to true or false depends on your collector
not on the type of query or sorting or you need scores. It gives the query engine a hint,
if it is possible to deliver the doc ids out of order.

Simple case is the example in the Collector JavaDocs: if you just mark the docids in an OpenBitSet,
the order is irrelevant (bitset is not faster/slower when it does not get the docs in correct
order). On the other hand collectors like TopDocs and so on can be optimized to be faster
when the docs come in order. One example would be: if you read stored fields of documents
using the setNextReader() given indexReader, it may be good to have the docs in order to avoid
back/forward seeking all the time.

bq. I'm also seeing this exception in many tests (DisMaxRequestHandlerTest, TestTrie, TestDistributedSearch)
which, I guess, are related to LUCENE-1630

I think, this is because you have a custom query type which implements an own weight. There
are possibilities to fix this using a wrapper, not sure.

> TrieRange support
> -----------------
>
>                 Key: SOLR-940
>                 URL: https://issues.apache.org/jira/browse/SOLR-940
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-940-LUCENE-1602.patch, SOLR-940-LUCENE-1602.patch, SOLR-940-LUCENE-1701.patch,
SOLR-940-newTrieAPI.patch, SOLR-940-newTrieAPI.patch, SOLR-940-rangequery.patch, SOLR-940-rangequery.patch,
SOLR-940-test.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch,
SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch
>
>
> We need support in Solr for the new TrieRange Lucene functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message