lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (SOLR-1145) Patch to set IndexWriter.defaultInfoStream from solr.xml
Date Fri, 19 Jun 2009 13:47:07 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721783#action_12721783
] 

Mark Miller edited comment on SOLR-1145 at 6/19/09 6:46 AM:
------------------------------------------------------------

I see your point Hoss.

But at the same time, this is a special debug log that I would likely want to see only when
I specifically turn it on to debug (usually for a Lucene dev to look at). Likely I just want
to see the log in isolation - Mike M will prob have a hard time looking through it mixed in
with all of the Solr logging :)

Now you can do that with log4j/jdk logging, but its a hassle. Youd have to setup a config
that captured the right package, and setup a file for it to write to... and it would likely
be a hassle for people when I said, hey just turn on the IndexWriter debug stream, and setup
your logging config to isolate it to a single file, and ...

And it just seems like you would almost never want the info dispersed with everything else
in the standard log.

TimeLoggingPrintStream isnt really to reinvent logging - its just to shove in a timestamp
as I guess Lucene doesn't.

So, I see your point, and I'm not really arguing against yet (Likely you have good counter
points), but thats the way I see it at the moment...

      was (Author: markrmiller@gmail.com):
    I see your point Hoss.

But at the same time, this is a special debug log that I would likely want to see only when
I specifically turn it on to debug (usually for a Lucene dev to look at). Likely I just want
to see the log in isolation - Mike M will prob have a hard time looking through it mixed in
with all of the Solr logging :)

Now you can do that with log4j, but its a a hassle. Youd have to setup a config that captured
the right package, and setup a file for it to write to... and it would likly be a hassle for
people when I said, hey just turn on the IndexWriter debug stream, and setup your logging
config to isolate it to a single file, and ...

And it just seems like you would almost never want the info dispersed with everything else
in the standard log.

TimeLoggingPrintStream isnt really to reinvent logging - its just to shove in a timestamp
as I guess Lucene doesn't.

So, I see your point, and I'm not really arguing against yet (Likely you have good counter
points), but thats the way I see it at the moment...
  
> Patch to set IndexWriter.defaultInfoStream from solr.xml
> --------------------------------------------------------
>
>                 Key: SOLR-1145
>                 URL: https://issues.apache.org/jira/browse/SOLR-1145
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Chris Harris
>             Fix For: 1.4
>
>         Attachments: SOLR-1145.patch, SOLR-1145.patch, SOLR-1145.patch
>
>
> Lucene IndexWriters use an infoStream to log detailed info about indexing operations
for debugging purpose. This patch is an extremely simple way to allow logging this info to
a file from within Solr: After applying the patch, set the new "defaultInfoStreamFilePath"
attribute of the solr element in solr.xml to the path of the file where you'd like to save
the logging information.
> Note that, in a multi-core setup, all cores will end up logging to the same infoStream
log file. This may not be desired. (But it does justify putting the setting in solr.xml rather
than solrconfig.xml.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message