Return-Path: 
 <solr-dev-return-16491-apmail-lucene-solr-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org
Received: (qmail 20665 invoked from network); 8 May 2009 18:46:43 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 8 May 2009 18:46:43 -0000
Received: (qmail 84809 invoked by uid 500); 8 May 2009 18:46:42 -0000
Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org
Received: (qmail 84742 invoked by uid 500); 8 May 2009 18:46:42 -0000
Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:solr-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:solr-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:solr-dev@lucene.apache.org>
List-Id: <solr-dev.lucene.apache.org>
Reply-To: solr-dev@lucene.apache.org
Delivered-To: mailing list solr-dev@lucene.apache.org
Received: (qmail 84732 invoked by uid 99); 8 May 2009 18:46:42 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 May 2009 18:46:42 +0000
X-ASF-Spam-Status: No, hits=2.2 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of jianhan@gmail.com designates
 74.125.44.28 as permitted sender)
Received: from [74.125.44.28] (HELO yx-out-2324.google.com) (74.125.44.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 May 2009 18:46:32 +0000
Received: by yx-out-2324.google.com with SMTP id 8so804120yxm.5
        for <solr-dev@lucene.apache.org>;
 Fri, 08 May 2009 11:46:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:in-reply-to:references
         :date:message-id:subject:from:to:content-type;
        bh=IFhD7/gUEeRZsy7JR8HwXn/wFSGAwV5fpwVOtwQbdJg=;
        b=bH/7fHdWGB0hgM4yBo7SS3oR+4eu2K8lMR0eVCKK5Ia8fqnFj+yDtLS5kGzN6hJXV+
         BEp5+GdBhRWyoO4UG9bFa8jxO1T7JOfJVin05QkiR2d9+jmo1qJ0/yZOBCckyUXHiBOp
         u9uu+22ItsTtbgANpIsIA5Ubq370K1OOmuCVY=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=LRS5ly3n+ZsdWkF3JR3tVNeuquOgiiBAoXqF84wjDhBsC/bygfYNmEj/VkCD4fuDF4
         kdJRpxFdII/r9T5tf/sNKXooKFXqqFotj6X0ADay8Mwm5VtQjAf0kcImGGbmpKe5arVL
         tdfEHrRVPOUii4tvcWSmT3gkyEE2BNLSh+Y4Q=
MIME-Version: 1.0
Received: by 10.151.40.5 with SMTP id s5mr440447ybj.260.1241808371899;
 Fri, 08
	May 2009 11:46:11 -0700 (PDT)
In-Reply-To: <879f9c1a0905051518v3dc1ca1aqe959fa3e98ee9033@mail.gmail.com>
References: <879f9c1a0905051518v3dc1ca1aqe959fa3e98ee9033@mail.gmail.com>
Date: Fri, 8 May 2009 11:46:11 -0700
Message-ID: <879f9c1a0905081146t64056882hbc507d9a66639d0d@mail.gmail.com>
Subject: Re: SolrDispatchFilter config parameter solrconfig-filename
From: Jian Han Guo <jianhan@gmail.com>
To: solr-dev@lucene.apache.org
Content-Type: multipart/alternative; boundary=0015174ff438e2dffe04696b0a3e
X-Virus-Checked: Checked by ClamAV on apache.org

--0015174ff438e2dffe04696b0a3e
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Ok, if there is no objection, I'll file a bug and create a patch for it.

Thanks,

Jianhan


On Tue, May 5, 2009 at 3:18 PM, Jian Han Guo <jianhan@gmail.com> wrote:

>
> Hi,
>
> I wanted to use this parameter to specify different solr configuration
> files for master and slave to simplify deployment procedure. Unfortunately,
> I can't dynamically replace the value of this parameter. Basically, what I
> want is
>
>   <filter>
>     <filter-name>SolrRequestFilter</filter-name>
>     <filter-class>org.apache.solr.servlet.SolrDispatchFilter</filter-class>
>     <init-param>
>       <param-name>solrconfig-filename</param-name>
>       <param-value>solrconfig-master.xml</param-value>
>     </init-param>
> </filter>
>
> for master instance, and
>
>   <filter>
>     <filter-name>SolrRequestFilter</filter-name>
>     <filter-class>org.apache.solr.servlet.SolrDispatchFilter</filter-class>
>     <init-param>
>       <param-name>solrconfig-filename</param-name>
>       <param-value>solrconfig-slave.xml</param-value>
>     </init-param>
> </filter>
>
> for slave instance.
>
> Ideally, if I can use system property for its value like in solrconfig.xml.
> For example,
>
>
>   <filter>
>     <filter-name>SolrRequestFilter</filter-name>
>     <filter-class>org.apache.solr.servlet.SolrDispatchFilter</filter-class>
>     <init-param>
>       <param-name>solrconfig-filename</param-name>
>       <param-value>${solr.config.filename: solrconfig.xml}</param-value>
>     </init-param>
> </filter>
>
> but I learned that in general we can't use system property in web.xml.
>
> I realize that I can use replication of config file to achieve this, but I
> thought that creates unnecessary dependencies for slaves on master instance.
>
> So here is my proposal:
>
> make SolrDispatchFilter look up another init parameter, say
> 'solrconfig-filename-property', and its value is a system property name, and
> if this property is set, we got the file name, otherwise nothing happens (of
> course, if both exist, 'solrconfig-filename' takes precedence). This will
> give us maxium flexibility of specifying configuration files for different
> instances.
>
> Your thoughts?
>
> Thanks,
>
> Jianhan
>
>
>

--0015174ff438e2dffe04696b0a3e--