lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Noble Paul നോബിള്‍ नोब्ळ् <noble.p...@corp.aol.com>
Subject Re: [jira] Commented: (SOLR-1154) allow specifying solr configuration file through system property to simplify deployment procedure in certain cases
Date Mon, 11 May 2009 17:12:34 GMT
in general , modifying web.xml is discouraged. so, this is the first
time someone is asking for config to be added into the configuration
of SolrDispatchFilter.

when you say the whole directory ,other than solrconfig.xml everything
else is a simple copy , right?

On Mon, May 11, 2009 at 10:20 PM, Jian Han Guo <jianhan@gmail.com> wrote:
> You are right that keeping directories for solr home can solve this problem.
> The only issue is that you then have to keep two copies of everything in the
> solr home directory, which is a potential maintenance problem. I still yet
> to figure out how to extract the common part of solrconfig.xml and
> solrconfig-slave.xml, but at least we only duplicate one file instead of the
> whole directory if this feature is available.
>
> Thanks,
>
> Jianhan
>
> On Sun, May 10, 2009 at 10:09 PM, Noble Paul (JIRA) <jira@apache.org> wrote:
>
>>
>>    [
>> https://issues.apache.org/jira/browse/SOLR-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707885#action_12707885]
>>
>> Noble Paul commented on SOLR-1154:
>> ----------------------------------
>>
>> replying to the mail http://markmail.org/message/52vj7lughfplxmks
>>
>> it is still possible to achieve what you want to do by setting a different
>> solr.solr.home from the system property. when you package your war keep two
>> instance directories one for master and another for slave. pass different
>> solr.solr.home as command line param when you start the server
>>
>> > allow specifying solr configuration file through system property to
>> simplify deployment procedure in certain cases
>> >
>> ------------------------------------------------------------------------------------------------------------------
>> >
>> >                 Key: SOLR-1154
>> >                 URL: https://issues.apache.org/jira/browse/SOLR-1154
>> >             Project: Solr
>> >          Issue Type: Improvement
>> >    Affects Versions: 1.4
>> >            Reporter: Jianhan
>> >            Priority: Minor
>> >             Fix For: 1.4
>> >
>> >         Attachments: SOLR-1154.patch
>> >
>> >   Original Estimate: 5h
>> >  Remaining Estimate: 5h
>> >
>> > Hi,
>> > I wanted to use this parameter to specify different solr configuration
>> files for master and slave to simplify deployment procedure. Unfortunately,
>> I can't dynamically replace the value of this parameter. Basically, what I
>> want is
>> >   <filter>
>> >     <filter-name>SolrRequestFilter</filter-name>
>> >
>> <filter-class>org.apache.solr.servlet.SolrDispatchFilter</filter-class>
>> >     <init-param>
>> >       <param-name>solrconfig-filename</param-name>
>> >       <param-value>solrconfig-master.xml</param-value>
>> >     </init-param>
>> > </filter>
>> > for master instance, and
>> >   <filter>
>> >     <filter-name>SolrRequestFilter</filter-name>
>> >
>> <filter-class>org.apache.solr.servlet.SolrDispatchFilter</filter-class>
>> >     <init-param>
>> >       <param-name>solrconfig-filename</param-name>
>> >       <param-value>solrconfig-slave.xml</param-value>
>> >     </init-param>
>> > </filter>
>> > for slave instance.
>> > Ideally, if I can use system property for its value like in
>> solrconfig.xml. For example,
>> >   <filter>
>> >     <filter-name>SolrRequestFilter</filter-name>
>> >
>> <filter-class>org.apache.solr.servlet.SolrDispatchFilter</filter-class>
>> >     <init-param>
>> >       <param-name>solrconfig-filename</param-name>
>> >       <param-value>${solr.config.filename: solrconfig.xml}</param-value>
>> >     </init-param>
>> > </filter>
>> > but I learned that in general we can't use system property in web.xml.
>> > I realize that I can use replication of config file to achieve this, but
>> I thought that creates unnecessary dependencies for slaves on master
>> instance.
>> > So here is my proposal:
>> > make SolrDispatchFilter look up another init parameter, say
>> 'solrconfig-filename-property', and its value is a system property name, and
>> if this property is set, we get the file name, otherwise nothing happens (of
>> course, if both exist, 'solrconfig-filename' takes precedence). This will
>> give us maximum flexibility of specifying configuration files for different
>> instances.
>> > Your thoughts?
>> > Thanks,
>> > Jianhan
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>



-- 
-----------------------------------------------------
Noble Paul | Principal Engineer| AOL | http://aol.com

Mime
View raw message