Return-Path: 
 <solr-dev-return-15864-apmail-lucene-solr-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org
Received: (qmail 15633 invoked from network); 2 Apr 2009 23:45:43 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 2 Apr 2009 23:45:43 -0000
Received: (qmail 22218 invoked by uid 500); 2 Apr 2009 23:45:42 -0000
Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org
Received: (qmail 22133 invoked by uid 500); 2 Apr 2009 23:45:42 -0000
Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:solr-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:solr-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:solr-dev@lucene.apache.org>
List-Id: <solr-dev.lucene.apache.org>
Reply-To: solr-dev@lucene.apache.org
Delivered-To: mailing list solr-dev@lucene.apache.org
Received: (qmail 22123 invoked by uid 99); 2 Apr 2009 23:45:42 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2009 23:45:42 +0000
X-ASF-Spam-Status: No, hits=-1999.8 required=10.0
	tests=ALL_TRUSTED,WHOIS_MYPRIVREG
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2009 23:45:34 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 02802234C051
	for <solr-dev@lucene.apache.org>; Thu,  2 Apr 2009 16:45:13 -0700 (PDT)
Message-ID: <601183787.1238715913009.JavaMail.jira@brutus>
Date: Thu, 2 Apr 2009 16:45:13 -0700 (PDT)
From: "Jason Shepherd (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Issue Comment Edited: (SOLR-1058) JNDI DataImporterHandler
In-Reply-To: <1844694438.1236639830559.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/SOLR-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695167#action_12695167 ] 

Jason Shepherd edited comment on SOLR-1058 at 4/2/09 4:44 PM:
--------------------------------------------------------------

I made one small change, reversing the boolean check of driver is null. I have uploaded the changes.

I used the Jndi source by adding the following to my data-config.xml

<dataSource type="JdbcDataSource" jndiName="jndiName" user="username" password="password"/>


      was (Author: jasinner):
    I made one small changed as follows. I have uploaded the changes.

I used the Jndi source by adding the following to my data-config.xml

<dataSource type="JdbcDataSource" jndiName="jndiName" user="username" password="password"/>

Changed 
from :

@@ -111,7 +113,9 @@
         throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Could not load driver: " + driver, e);
       }
     } else {
-      throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Driver must be specified");
+      if(jndiName != null){
+        throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Driver must be specified");
+      }
     }
 
     String s = initProps.getProperty("maxRows");



to:

@@ -111,7 +113,9 @@
         throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Could not load driver: " + driver, e);
       }
     } else {
-      throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Driver must be specified");
+      if(jndiName == null){
+        throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Driver must be specified");
+      }
     }
 
     String s = initProps.getProperty("maxRows");
  
> JNDI DataImporterHandler
> ------------------------
>
>                 Key: SOLR-1058
>                 URL: https://issues.apache.org/jira/browse/SOLR-1058
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>         Environment: Java Servlet Contaner, for example JBoss, or Tomcat
>            Reporter: Jason Shepherd
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-1058.patch, SOLR-1058.patch, SOLR-1058.patch
>
>
> Please make the Callable<Connection> factory field of the JdbcDataSource a protected field.
> Follow the discussion on the thread linked below, to enable the use of JNDI lookup for a JdbcDataSource this field will need to be set by a subclass (JndiJdbcDataSource).
> http://www.nabble.com/DataImportHandler-that-uses-JNDI-lookup-tt22408996.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.