Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org Received: (qmail 65004 invoked from network); 24 Apr 2009 00:15:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Apr 2009 00:15:01 -0000 Received: (qmail 7447 invoked by uid 500); 24 Apr 2009 00:15:00 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 7363 invoked by uid 500); 24 Apr 2009 00:15:00 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 7353 invoked by uid 99); 24 Apr 2009 00:14:59 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Apr 2009 00:14:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Apr 2009 00:14:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 70782234C4AE for ; Thu, 23 Apr 2009 17:14:30 -0700 (PDT) Message-ID: <1275876349.1240532070459.JavaMail.jira@brutus> Date: Thu, 23 Apr 2009 17:14:30 -0700 (PDT) From: "Mark Miller (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Commented: (SOLR-1088) newSearcher(String name, boolean readOnly) is broken In-Reply-To: <1327005723.1238090535409.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702171#action_12702171 ] Mark Miller commented on SOLR-1088: ----------------------------------- I think I added that method with the readonly patch - I figured it was a good idea to allow a searcher of either type (you get a non readonly otherwise). I don't know why it was commented out though (there really should be a comment about that included). We should drop it or fix it for sure. I think it makes sense to keep, and I'd just fix it, but I don't know why it was commented out to begin with so... > newSearcher(String name, boolean readOnly) is broken > ---------------------------------------------------- > > Key: SOLR-1088 > URL: https://issues.apache.org/jira/browse/SOLR-1088 > Project: Solr > Issue Type: Bug > Reporter: Hoss Man > Fix For: 1.4 > > > Noted on the mailing list while investigating something semi-related, the method SolrCore.newSearcher(String name, boolean readOnly) doesn't work as advertised (the readOnly option is completely ignored) > the method isn't used anywhere in Solr (that i could find) but it might be used by clients ... we should deal with this in some way prior to the 1.4 release (either fix; fix & deprecate; or document problem and deprecate) > http://www.nabble.com/Re%3A-Lucene-sync-bottleneck--p22237748.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.