lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wojtek Piaseczny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-748) FacetComponent helper classes are package restricted
Date Thu, 30 Apr 2009 16:46:30 GMT

    [ https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704695#action_12704695
] 

Wojtek Piaseczny commented on SOLR-748:
---------------------------------------

Shalin,

1. Makes sense.
2. Using public access seems dangerous, but is consistent with a lot of the code in this project,
so it's probably the right solution.
3. Makes sense.

I'll post a patch shortly.

(Also, thanks for taking this issue!)

> FacetComponent helper classes are package restricted
> ----------------------------------------------------
>
>                 Key: SOLR-748
>                 URL: https://issues.apache.org/jira/browse/SOLR-748
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Wojtek Piaseczny
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: 748.patch, SOLR-748.patch, SOLR-748.patch, SOLR-748.patch
>
>
> Original discussion:
> http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html
> The FacetComponent class uses several helper classes that currently have package-restricted
access. This makes it impossible to extend the FacetComponent without rewriting most of its
functionality.
> A proposed solution is to make those classes public and make their public member variables
accessibly only through get and set functions (i.e. make them private).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message