lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Noble Paul നോബിള്‍ नोब्ळ् <noble.p...@gmail.com>
Subject Re: SOLR-1106 - Custom Admin Action handler
Date Wed, 15 Apr 2009 05:45:39 GMT
On Mon, Apr 13, 2009 at 10:03 PM, Kay Kay <kaykay.unique@gmail.com> wrote:
> These custom action handlers need not be residing in solr . Hence I needed a
> hook ( listener ) that they can register themselves with and be loaded by
> the SolrResourceLoader ( ./lib/*.jar ) .  Also I believe the default
> handlers are very useful , necessary and mandatory and hence ported them to
> the listener for consistency purposes.
>
> Also - if we have a protected method called invokeCommand() - how do we
> inject that type as the admin handler ( as opposed to CoreAdminHandler) .
> Right now - the type information seems hardcoded in CoreContainer though.

There is no mean to inject that currently, But that can be made
possible by an extra attribute in the <cores> tag . say <core
adminHandler="foo.FooHandler">

We will have to refactor the code a bit so that you may be able to
extend the default core admin handler
>
>  // ---------------- Multicore self related methods ---------------
>  /**
>   * Creates a CoreAdminHandler for this MultiCore.
>   * @return a CoreAdminHandler
>   */
>  protected CoreAdminHandler createMultiCoreHandler() {
>    return new CoreAdminHandler() {
>      @Override
>      public CoreContainer getCoreContainer() {
>        return CoreContainer.this;
>      }
>    };
>  }
>
>
> 2009/4/13 Noble Paul നോബിള്‍ नोब्ळ् <noble.paul@gmail.com>
>
>> Hi Kay,
>>
>> The idea of one handler per command looks like an overkill. How about
>> having a protected methods for all the known commands and have a
>> separate method invokeCommand() which can choose to implement any
>> extra commands if need be. This way the changes needed would be
>> minimal.
>>
>> On Mon, Apr 13, 2009 at 8:53 PM, Kay Kay <kaykay.unique@gmail.com> wrote:
>> > For one of our projects - we need custom admin monitoring hooks that gets
>> > access to multiple cores for a given solr web app (through the
>> CoreContainer
>> > interface).
>> >
>> > There are common admin handler commands with the actions - register /
>> swap /
>> > load etc. that seem to be available by default.
>> >
>> > I have submitted a patch to add custom admin handlers , against custom
>> > actions  ( that also refactors the existing action handlers that are
>> > available by default as well ).
>> >
>> > This would be useful to extend the handlers that need access to multiple
>> > cores.  Just curious if this is something that could be looked into .
>> > Thanks.
>> >
>>
>>
>>
>> --
>> --Noble Paul
>>
>



-- 
--Noble Paul

Mime
View raw message