lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1099) FieldAnalysisRequestHandler
Date Tue, 14 Apr 2009 09:27:15 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698711#action_12698711
] 

Shalin Shekhar Mangar commented on SOLR-1099:
---------------------------------------------

{quote}The public API for the AnalysisRequestHandler will change in the context of the response.
{quote}

I was assuming that the output format of AnalysisRequestHandler and FieldAnalysisRequestHandler
remains exactly as they are today and the refactoring is just to abstract common code into
a base class.

{quote}
Furthermore, it's probably wise to rename the AnalysisRequestHandler to DocumentAnalysisRequestHandler
(more expressive name and also consistent with the FieldAnalysisRequestHandler). Another option
is to do this refactoring anyway, and leave the AnalysisRequestHandler as is and only deprecate
it. So basically we'll have 4 classes:

AnalysisRequestHanlderBase
FieldAnalysisRequestHanlder
DocumentAnalysisRequestHandler
AnalysisRequestHandler (deprecated)
{quote}

Agreed. But the output of DocumentAnalysisRequestHandler will look exactly like what AnalysisRequestHandler
returns today, right?

{quote}it would be also be wise to reimplement the anaysis.jsp to use this new handler and
clean it up from all the analysis (now duplicate) logic code.{quote}

Agreed.

> FieldAnalysisRequestHandler
> ---------------------------
>
>                 Key: SOLR-1099
>                 URL: https://issues.apache.org/jira/browse/SOLR-1099
>             Project: Solr
>          Issue Type: New Feature
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Uri Boness
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: FieldAnalysisRequestHandler_incl_test.patch
>
>
> The FieldAnalysisRequestHandler provides the analysis functionality of the web admin
page as a service. This handler accepts a filetype/fieldname parameter and a value and as
a response returns a breakdown of the analysis process. It is also possible to send a query
value which will use the configured query analyzer as well as a showmatch parameter which
will then mark every matched token as a match.
> If this handler is added to the code base, I also recommend to rename the current AnalysisRequestHandler
to DocumentAnalysisRequestHandler and have them both inherit from one AnalysisRequestHandlerBase
class which provides the common functionality of the analysis breakdown and its translation
to named lists. This will also enhance the current AnalysisRequestHandler which right now
is fairly simplistic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message