lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uri Boness (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1099) FieldAnalysisRequestHandler
Date Tue, 14 Apr 2009 10:08:14 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698723#action_12698723
] 

Uri Boness commented on SOLR-1099:
----------------------------------

{quote}
We copy AnalysisRequestHandler (ARH) to DocumentAnalysisRequestHandler and deprecate ARH.
{quote}
true, but it will be enhanced with functionality and support more extensive analysis breakdown
(e.g. adding a query analysis and showmatch support)

{quote}
We extract common code (if any) of ARH and FieldARH in to a base class AnalysisRequestHandlerBase,
as you suggested
{quote}
true

{quote}
We modify analysis.jsp to use FieldARH (maybe as a separate issue)
{quote}
probably a separate issue is more appropriate.

{quote}
You do not need to support AnalysisRequestHandler's format because it will also exist by the
name of DocumentAnalysisRequestHandler. Since FieldARH is a new handler, it does not need
to be back-compatible with ARH. Supporting the old format is a nice-to-have feature but not
necessary.
{quote}
True. The old AnalysisRequestHandler will be deprecated and it's (enhanced) functionality
will be available via the DocumentAnalysisRequestHandler. That said, it would be nice to be
backward compatible as much as possible for those who are using the old ARH already (I suspect
not many are using it anyway as it's mostly used for tooling and debugging). I do believe
that both the new DocumentARH and the FieldARH are useful for different purposes due the nature
of their differences as I mentioned above.

I hope this makes things a bit clearer :-)

> FieldAnalysisRequestHandler
> ---------------------------
>
>                 Key: SOLR-1099
>                 URL: https://issues.apache.org/jira/browse/SOLR-1099
>             Project: Solr
>          Issue Type: New Feature
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Uri Boness
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: FieldAnalysisRequestHandler_incl_test.patch
>
>
> The FieldAnalysisRequestHandler provides the analysis functionality of the web admin
page as a service. This handler accepts a filetype/fieldname parameter and a value and as
a response returns a breakdown of the analysis process. It is also possible to send a query
value which will use the configured query analyzer as well as a showmatch parameter which
will then mark every matched token as a match.
> If this handler is added to the code base, I also recommend to rename the current AnalysisRequestHandler
to DocumentAnalysisRequestHandler and have them both inherit from one AnalysisRequestHandlerBase
class which provides the common functionality of the analysis breakdown and its translation
to named lists. This will also enhance the current AnalysisRequestHandler which right now
is fairly simplistic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message