lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-940) TrieRange support
Date Tue, 07 Apr 2009 18:42:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696681#action_12696681
] 

Uwe Schindler commented on SOLR-940:
------------------------------------

One note to sorting:
I am not really sure, if sorting works with Solr. The Sortfield returned by TrieUtils.getSortField
contains an own parser (new feature in Lucene 2.9). When looking through the solr code, searching
for SortField in trunk, I noticed, that QueryComponent has own comparators and FieldCache
code (duplicating the Lucene code), and ignoring the parser given in SortField (the parser
is not passed to FieldCache.getInts() & Co.).

If this is the case, it will simply not work. As I do not know anything about the internals
of Solr and what QueryComponent does, so can you create a test-case that tests sorting of
trie fields?

By the way: In QueryComponent is a package-private StringFieldable just to convert the strings.
Why not simply use a conventional Field instance to do this, why implement the whole interface?
You can do everything done with this StringFieldable with Field, too. This is the problem
of the omitTf thing: the interface changed again in Lucene 2.9, needing a change in this class.
Replacing this by a simple reuseable Field instance solves the interface problem completely.

> TrieRange support
> -----------------
>
>                 Key: SOLR-940
>                 URL: https://issues.apache.org/jira/browse/SOLR-940
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-940-newTrieAPI.patch, SOLR-940-newTrieAPI.patch, SOLR-940-rangequery.patch,
SOLR-940-rangequery.patch, SOLR-940-test.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch,
SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch, SOLR-940.patch
>
>
> We need support in Solr for the new TrieRange Lucene functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message