lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Hostetter <hossman_luc...@fucit.org>
Subject Re: svn commit: r756703 - /lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java
Date Sat, 21 Mar 2009 02:48:43 GMT

: +      OutputStreamWriter writer = new OutputStreamWriter(os, "UTF-8");

Minor nit, but using something like

   public static final Charset UTF_8 = Charset.forName("UTF-8");
      ...
      OutputStreamWriter writer = new OutputStreamWriter(os, UTF_8);

...would be a little cleaner here.  no reason to pay the charset lookup 
cost everytime for a hardcoded constant.



-Hoss


Mime
View raw message