lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <>
Subject [jira] Commented: (SOLR-1060) a new DIH EnityProcessor allowing text file lists of files to be indexed
Date Fri, 13 Mar 2009 07:27:50 GMT


Shalin Shekhar Mangar commented on SOLR-1060:

My concern is that we have two data sources whose names identify their respective functionality.
With this change FileDataSource becomes redundant and HttpDataSource does not give the impression
that it can read files too. I assume that everyone will be generating the changeset using
their own sweet tools/programs. Therefore it is a simple task for the changeset generator
to generate http/file separately or mark them differently. Then one can use different root

The ChangeListEntityProcessor should not care whether the changelist contains a filepath or
url -- they are all strings to it which should be added to a map and passed along. If it is
a delete set, then it should set $deleteDocByQuery or $deleteDocById along with $skipDoc and
return. The ChangeListEntityProcessor should not try to collaborate with any other entity.
It does not need to know about them just as current EntityProcessor do not know about each

For example:
  <dataSource name="file" type="FileDataSource"/>
    <entity name="changeSet" processor="ChangeSetEntityProcessor"
      <entity name="indexer" processor="XPathEntityProcessor"


Here the ${changeSet.filename} is just a normal key/val in the changeSet entity's row map.

> a new DIH EnityProcessor allowing text file lists of files to be indexed
> ------------------------------------------------------------------------
>                 Key: SOLR-1060
>                 URL:
>             Project: Solr
>          Issue Type: New Feature
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: Fergus McMenemie
>             Fix For: 1.4
>         Attachments: SOLR-1060.patch
>   Original Estimate: 120h
>  Remaining Estimate: 120h
> I have finished a new DIH EntityProcessor. It is designed around the idea that whatever
demon is used to maintain your content store it is likely to drop a report or log file explaining
what has changed within your content store. I wish to use this report file to control the
indexing of the new or changed content and the removal of old content. The report files, perhaps
from un-tar or un-zip, are likely to reference jpegs and directory stubs which need to be
ignored. I assumed a file based content repository but this should be expanded to handle URI's
as well
> I feel that the current FileListEntityProcessor is poorly named. It should be called
the dirWalkEntityProcessor or dirCrawlEntityProcessor or such. And this new EntityProcessor
should have the name FileListEntityProcessor. However what is done is done. I then came up
with manifestEnityProcessor which I thought suited, manifest files are all over the content
sets I deal with and the dictionary definition seemed close enough ("ships manifest"). However
how about ChangeListEntityProcessor
> {code}
>        <entity name="jc"
>                processor="ManifestEntityProcessor"
>                baseDir="/Volumes/Techmore/ts/aaa/schema/data"
>                rootEntity="false"
>                dataSource="null"
>                allowRegex="^.*\.xml$"
>                blockRegex="usc2009"
>                manifestFileName="/Volumes/ts/man-find.txt"
>                docAddRegex=".*"
>                >
> {code}
> The new entity fields are as follows.
>    *manifestFileName* is the required location of the manifest file. If this value is
relative, it assumed to be relative to baseDir.
>    *allowRegex* is an optional attribute that if present discards any line which does
not match the regExp
>    *blockRegex* is an optional attribute that is applied after any allowRegex and discards
any line which matches the regExp
>    *docAddRegex* is a required regex to identify lines which when matched should cause
docs to be added to the index. As well as matching the line it should also return the portion
of the line which contains the filepath as group(1)
>    *docDeleteRegex* is an optional value of a regex to identify documents which when
matched should be deleted from the index. As well as matching the line it should also return
the portion of the line which contains the filepath as group(1) **PLANNED**

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message