lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Hostetter <hossman_luc...@fucit.org>
Subject Re: svn commit: r742106 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/handler/XMLLoader.java
Date Fri, 13 Feb 2009 02:04:03 GMT
:  
: +29. SOLR-976: deleteByQuery is ignored when deleteById is placed prior to deleteByQuery
in a <delete>.
: +    Now both delete by id and delete by query can be specified at the same time as follows.
(koji)
: +      <delete>
: +        <id>05991</id><id>06000</id>
: +        <query>office:Bridgewater</query><query>office:Osaka</query>
: +      </delete>
: +

is this really true?  the patch only modifies XMLLoader, but don't 
DeleteUpdateCommand and RunUpdateProcessor also need to be changed to make 
this work ... there's was no test commited with this patch so i'm not 
convinced, and i see this code in RunUpdateProcessor...

    if( cmd.id != null ) {
      updateHandler.delete(cmd);
    }
    else {
      updateHandler.deleteByQuery(cmd);
    }



-Hoss


Mime
View raw message